Fix arm pop reg access #2718
Merged
Fix arm pop reg access #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environment, the iteration order does not follow the alphabetical order, so that the patches cannot be applied cleanly. Add extra sorting to ensure the order.
github-actions
bot
added
ARM
Rot127
approved these changes
May 24, 2025
Rot127
requested changes
May 24, 2025
Rot127
approved these changes
May 24, 2025
kabeor
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fix the reg access type of arm thumb pop instruction.
Test plan
./suite/cstest/cstest ../tests/details/arm.yamlClosing issues
closes #2713